Merged
Conversation
njvrzm
force-pushed
the
njvrzm/aws-sdk-v2
branch
from
9f0773a to
7ec6f68
Compare
idastambuk
approved these changes
Jan 22, 2025
Contributor
idastambuk
left a comment
idastambuk
left a comment
There was a problem hiding this comment.
Tested manually, looks good
njvrzm
force-pushed
the
njvrzm/aws-sdk-v2
branch
from
7ec6f68 to
fec25dc
Compare
Contributor
Author
|
Reupping the review request because I've migrated this to use the new v2 auth mechanism of grafana-aws-sdk. |
njvrzm
force-pushed
the
njvrzm/aws-sdk-v2
branch
from
fec25dc to
e237944
Compare
njvrzm
force-pushed
the
njvrzm/aws-sdk-v2
branch
from
e237944 to
7ea1eae
Compare
njvrzm
force-pushed
the
njvrzm/aws-sdk-v2
branch
from
7ea1eae to
ae5c0fc
Compare
kevinwcyu
approved these changes
Apr 25, 2025
This was referenced May 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This manages athena's direct use of aws-sdk-go-v2 and updates it to use our fork of the athenadriver package, which has also been updated.